[FFmpeg-devel] [PATCH v3 2/9] avcodec/av1dec: initialize AFGS1 VSC metadata

[James Almer]

On 3/15/2024 9:23 AM, Niklas Haas wrote:
> On Fri, 15 Mar 2024 09:20:04 -0300 James Almer <jamrial at gmail.com> wrote:
>> On 3/15/2024 8:58 AM, Niklas Haas wrote:
>>> From: Niklas Haas <git at haasn.dev>
>>>
>>> Unused by AV1, but should still be set properly.
>>
>> The doxy for av_film_grain_params_alloc() says "Allocate an
>> AVFilmGrainParams structure and set its fields to default values", so
>> this should be done there.
> 
> This function doesn't know whether the film grain is of type AV1 or
> H274, and so cannot set the correct codec-specific parameter defaults.
> 
> Unless, of course, we add these fields to the common struct, as
> discussed above. (Or if we add the type to the function signature)

We can't change the function signature, but we can add the fields to the 
common struct.
Just leave a comment about reordering the fields in the next bump (Which 
hopefully will not be forgotten).