[FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts

Michael Niedermayer michael at niedermayer.cc
Tue Mar 19 02:15:54 EET 2024


On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote:
> - Only parse the defined masks in dwChannelMask, unless strict_std_compliance
>   is less than normal. This matches with the behaviour of the wav muxer.
> - Ignore additional bits in dwChannelMasks as the MS documentation suggests [1]
> - Assume UNKNOWN channels for missing bits as the MS documentation suggests [1]
> 
> [1] https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653308(v=vs.85)#details-about-dwchannelmask
> 
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/riffdec.c | 28 +++++++++++++++++++++++++---
>  1 file changed, 25 insertions(+), 3 deletions(-)

breaks:
./ffmpeg  -i ~/tickets/2859/5.1plusdownmix.wav -ac 2 -t 100 -bitexact -c:a aac -y /tmp/2859-frenchspeack-nolibfaac.mp4

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240319/9474dde1/attachment.sig>


More information about the ffmpeg-devel mailing list