[FFmpeg-devel] [PATCH 2/3] avfilter: add an LCEVC decoding filter

[Kieran Kunhya]

On Tue, 19 Mar 2024 at 15:27, James Almer <jamrial at gmail.com> wrote:

> On 3/19/2024 12:20 PM, Kieran Kunhya wrote:
> > On Tue, 19 Mar 2024 at 15:05, James Almer <jamrial at gmail.com> wrote:
> >
> >> On 3/19/2024 11:56 AM, Andreas Rheinhardt wrote:
> >>> James Almer:
> >>>> Signed-off-by: James Almer <jamrial at gmail.com>
> >>>> ---
> >>>>    configure                |   4 +
> >>>>    libavfilter/Makefile     |   1 +
> >>>>    libavfilter/allfilters.c |   1 +
> >>>>    libavfilter/vf_lcevc.c   | 466
> +++++++++++++++++++++++++++++++++++++++
> >>>>    4 files changed, 472 insertions(+)
> >>>>    create mode 100644 libavfilter/vf_lcevc.c
> >>>>
> >>>> diff --git a/configure b/configure
> >>>> index e019d1b996..4022d13f76 100755
> >>>> --- a/configure
> >>>> +++ b/configure
> >>>> @@ -224,6 +224,7 @@ External library support:
> >>>>      --enable-libcdio         enable audio CD grabbing with libcdio
> [no]
> >>>>      --enable-libcodec2       enable codec2 en/decoding using
> libcodec2
> >> [no]
> >>>>      --enable-libdav1d        enable AV1 decoding via libdav1d [no]
> >>>> +  --enable-liblcevc_dec    enable AV1 decoding via liblcevc_dec [no]
> >>>
> >>> How is this filter supposed to decode AV1 if it does not even get
> >>> AVPackets? It seems to be for decoding an EVC enhancment layer instead.
> >>
> >> Simple, it doesn't. It's a copy-paste fail from my part.
> >> Fixed locally.
> >>
> >>
> >  From https://github.com/v-novaltd/LCEVCdec
> > " This software is protected by copyrights and other intellectual
> property
> > rights and no license is granted to any such rights. If you would like to
> > obtain a license to compile, distribute, or make any other use of this
> > software, please contact V-Nova Limited info at v-nova.com."
> >
> > So you want to include a library that requires ffmpeg users to obtain a
> > licence to compile?
>
> Would adding it to the nonfree list be enough? But it's true that most
> users would not be aware of the aforementioned limitations.
>
>
This is a slippery slope to adding whatever binary blob. As the decoder is
de-facto a binary blob.

Kieran