[FFmpeg-devel] [PATCH v5 1/4] avformat/rcwtdec: add RCWT Closed Captions demuxer

[Michael Niedermayer]

On Tue, Mar 19, 2024 at 12:39:10PM -0500, Marth64 wrote:
> Signed-off-by: Marth64 <marth64 at proxyid.net>
> ---
>  Changelog                |   2 +-
>  doc/demuxers.texi        |  29 ++++++++
>  libavformat/Makefile     |   1 +
>  libavformat/allformats.c |   1 +
>  libavformat/rcwtdec.c    | 148 +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 180 insertions(+), 1 deletion(-)
>  create mode 100644 libavformat/rcwtdec.c
[...]

> +static int rcwt_probe(const AVProbeData *p)
> +{
> +    return p->buf_size > RCWT_HEADER_SIZE &&
> +           AV_RB16(p->buf) == 0xCCCC && AV_RB8(p->buf + 2) == 0xED ? 50 : 0;
> +}

this fails

tools/probetest 256 4096

Failure of rcwt probing code with score=50 type=2 p=F01 size=16

can you make the test more robust ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240319/0cb9e8c8/attachment.sig>