[FFmpeg-devel] [PATCH 1/4] fftools/ffmpeg_enc: strip DOVI config record for AV1

Anton Khirnov anton at khirnov.net
Thu Mar 21 12:16:57 EET 2024


Quoting Niklas Haas (2024-03-19 20:16:39)
> From: Niklas Haas <git at haasn.dev>
> 
> AV1 streams don't use configuration records, so delete them when
> encoding to AV1. Ideally this would be, as the comment suggests, handled
> at the frame-level (and stripped by the av1 encoder), but given the
> status quo of copying the packet-level data here directly, we should
> definitely make an effort to strip it.
> ---
>  fftools/ffmpeg_enc.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

I'm very much not a fan of having codec-specific code in ffmpeg CLI. It
implies that every single caller must now be aware of this
(undocumented?) interaction of this specific side data with this
specific codec ID.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list