[FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

[Paul B Mahol]

On Wed, Mar 20, 2024 at 11:55 PM Yiğithan Yiğit <yigithanyigit35 at gmail.com>
wrote:

>
> > On Mar 21, 2024, at 12:10 AM, Paul B Mahol <onemda at gmail.com> wrote:
> >
> > Why? This is pointless.
> >
> > volumedetect have histogram output, float patch does not have it at all.
> > Use astats filter.
> >
> > On Wed, Mar 20, 2024 at 9:47 PM Yiğithan Yiğit <
> yigithanyigit35 at gmail.com>
> > wrote:
> >
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> >>
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe”.
>
> I am a beginner/student also new at open source but I love FFmpeg and
> using in my daily life. From my perspective volumedetect way more user
> friendly. I believe adding this patch would be useful to people such as
> #9613. The reason lack of histogram output for float mostly for my
> indecision about range of the histogram. I am open the suggestions and
> after that I can make a new patch.
>

It is trivial (to some people) to add histogram per dB for float/double
inputs.
But this patch just does some extremely trivial math calculations so that
float input have completely different output from integer ones.
That is very odd and unfriendly from my perspective.

Besides if you only interested in discrete sample audio peak finder in
audio input use astats and measure_overall=Peak_level options.
Yes they are not default on. Because more statistics are more important
than single number.

I'm not against adding proper and useful and correct float/double support
to volumedetect, but it needs to have same/similar structure of output as
integer sample format input audio, otherwise it just looks lazy and prone
for users wondering what is going on when they use different sample formats
in theirs graphs.


>
> Best Regards
> Yigithan
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>