[FFmpeg-devel] [PATCH 01/13] avformat/mp3enc: Improve query_codec

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Fri Mar 22 14:13:27 EET 2024


Andreas Rheinhardt:
> Signal that anything except MP3 and the ID3V2 attached pic types
> are forbidden.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavformat/mp3enc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c
> index cb250a46ca..4a02a45069 100644
> --- a/libavformat/mp3enc.c
> +++ b/libavformat/mp3enc.c
> @@ -495,12 +495,16 @@ static int mp3_write_trailer(struct AVFormatContext *s)
>  static int query_codec(enum AVCodecID id, int std_compliance)
>  {
>      const CodecMime *cm= ff_id3v2_mime_tags;
> +
> +    if (id == AV_CODEC_ID_MP3)
> +        return 1;
> +
>      while(cm->id != AV_CODEC_ID_NONE) {
>          if(id == cm->id)
>              return MKTAG('A', 'P', 'I', 'C');
>          cm++;
>      }
> -    return -1;
> +    return 0;
>  }
>  
>  static const AVOption options[] = {

Will apply this patchset tomorrow unless there are objections.

- Andreas



More information about the ffmpeg-devel mailing list