[FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: pass first video AVFrame's side data to encoder

[Anton Khirnov]

Quoting James Almer (2024-03-22 20:38:38)
> On 3/22/2024 6:52 AM, Anton Khirnov wrote:
> > I objected to this indiscriminate copying in a previous review.
> > 
> > There is no reason to expect side data to apply to the whole stream just
> > because it happens to apply to the first frame. For many side data types
> > it does not even make sense, as they are fundamentally per-frame.
> 
> So this would need to be handled by having decoders export global side 
> data in decoded_side_data directly, so there's no need to take them from 
> frames here (which would include per frame side data, like hdr10 and 
> closed captions), right?

That's not enough, you still need to propagate this data through the
filtergraph.

I'm leaning towards something like a side data descriptor, that would
tell callers (among other things) whether a side data type is meaningful
in global headers.

-- 
Anton Khirnov