[FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg_enc: only promote first frame side data to global when meaningful

Anton Khirnov anton at khirnov.net
Sat Mar 23 15:04:07 EET 2024


Skip those side data types that do not make sense as global side data.
---
 fftools/ffmpeg_enc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
index f01be1c22f..6a91fd0398 100644
--- a/fftools/ffmpeg_enc.c
+++ b/fftools/ffmpeg_enc.c
@@ -247,6 +247,11 @@ int enc_open(void *opaque, const AVFrame *frame)
         enc_ctx->chroma_sample_location = frame->chroma_location;
 
         for (int i = 0; i < frame->nb_side_data; i++) {
+            const AVSideDataDescriptor *desc = av_frame_side_data_desc(frame->side_data[i]->type);
+
+            if (!desc || !(desc->props & AV_SIDE_DATA_PROP_GLOBAL))
+                continue;
+
             ret = av_frame_side_data_clone(
                 &enc_ctx->decoded_side_data, &enc_ctx->nb_decoded_side_data,
                 frame->side_data[i], AV_FRAME_SIDE_DATA_FLAG_UNIQUE);
-- 
2.43.0



More information about the ffmpeg-devel mailing list