[FFmpeg-devel] [PATCH v9 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events

Marth64 marth64 at proxyid.net
Tue Mar 26 17:48:12 EET 2024


> is the move needed? (but not blocking)
It is not needed, but the code flows better I think in terms of
readability. I think it feels cleaner to say, "set up `sub` then add it to
the array" vs. "set up sub's data, add it to the array, then set up its
other fields". But, I am good either way and on stand by if you request me
to change it.

Thank you for the review.


More information about the ffmpeg-devel mailing list