[FFmpeg-devel] [PATCH v3] avformat: enable UDP IPv6 multicast interface selection using localaddr

[Rémi Denis-Courmont]

Le keskiviikkona 27. maaliskuuta 2024, 10.53.25 EET Ignjatović, Lazar (RS) a 
écrit :
> This message has been marked as Public on 03/27/2024 08:53Z.
> 
> On Tuesday, March 26, 2024 7:26 PM Rémi Denis-Courmont wrote:
> > Both patches -1 for same reasons as before and that's unnecessary,
> > functionally incorrect and potentially racy, enumeration of local
> > interfaces.
> Enumeration of interfaces is done only for IPv4
> MCAST_JOIN_SOURCE_GROUP/MCAST_BLOCK_SOURCE within zone index patch. Adding
> a separate parameter just for this seems pointless to me. Would removal of
> this, and reverting back to how it was ( = 0; // default interface in every
> case), address your concerns?

I have mixed feelings about changing how IPv4 works. Sure, it provides better 
consistency, and it is easier to remember an interface name than an IP address 
(especially if it is dynamically assigned). But it will also break backward 
compatibility. Not that I care about this specific hypothetical breakage, but 
somebody else very well might.

Either way, if you change how IPv4 works, you need to do it as a separate 
patch to adding IPv6 support. Avoiding reviewer confusion is just one of 
several reasons.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/