[FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

Anton Khirnov anton at khirnov.net
Thu Mar 28 10:02:29 EET 2024


Quoting Kieran Kunhya (2024-03-27 15:13:12)
> On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> > > ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Thu Feb
> > 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] |
> > committer: Anton Khirnov
> > >
> > > lavf/demux: stop calling avcodec_close()
> > >
> > > Replace it with recreating the codec context.
> > >
> > > This is the last remaining blocker for deprecating avcodec_close().
> > >
> > > >
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> > > ---
> > >
> > >  libavformat/demux.c | 61
> > ++++++++++++++++++++++++++++++++++++++++++++++++-----
> > >  1 file changed, 56 insertions(+), 5 deletions(-)
> >
> > This breaks ffprobe "Closed Caption" output
> > before:
> > Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive),
> > 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn
> >
> 
> Closed Captions are sparse side data, we shouldn't be exposing it like this
> to begin with.

+1

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list