[FFmpeg-devel] [PATCH 1/2] lavf/subtitles: Add ff_text_peek_r16(), only accept \r, \n, \r\n and \r\r\n line endings

Tomas Härdin git at haerdin.se
Sat Mar 30 02:08:57 EET 2024


Here's an alternative first patch that rolls patch 1+3 into one. I'd
like some feedback on this before I continue hacking on patch 2. While
I don't like that we accept any old broken srt file, especially without
knowing what software made it, I'm not completely opposed to
compromising in this specific case. But I'd rather we didn't, and stuck
to \r, \n and \r\n. What I really don't want is runs of \r being eaten
without being "terminated" by a \n, because this messes up Mac support.

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-subtitles-Add-ff_text_peek_r16-only-accept-r-n-.patch
Type: text/x-patch
Size: 3379 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240330/b6b7b664/attachment.bin>


More information about the ffmpeg-devel mailing list