[FFmpeg-devel] [PATCH] libavutil/ppc: defines involving bit shifts should be unsigned

[Brad Smith]

I had a bigger diff to handle all of the same type of flags in the same
manner, but I can post that separately.

LGTM.

On 2024-11-02 2:13 a.m., Sean McGovern wrote:
> Otherwise, these can overflow at the boundaries of the integer type.
> ---
>   libavutil/ppc/cpu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c
> index 62d495ec1d..9f9c073434 100644
> --- a/libavutil/ppc/cpu.c
> +++ b/libavutil/ppc/cpu.c
> @@ -53,9 +53,9 @@
>   #define AT_HWCAP2            26
>   #endif
>   
> -#define HWCAP_PPC_VSX        (1 << 7)
> -#define HWCAP_PPC_ALTIVEC    (1 << 28)
> -#define HWCAP2_PPC_ARCH_2_07 (1 << 31)
> +#define HWCAP_PPC_VSX        (1U << 7)
> +#define HWCAP_PPC_ALTIVEC    (1U << 28)
> +#define HWCAP2_PPC_ARCH_2_07 (1U << 31)
>   
>   /**
>    * This function MAY rely on signal() or fork() in order to make sure AltiVec