[FFmpeg-devel] [PATCH] fftools/ffplay: fix crash when vk renderer is null

[Leandro Santiago]

My patch formatting was broken by my email client, and I resent it, but it created a new thread in the mailing list. Please let me know if I should resent it as a reply on the same thread.

31 Oct 2024 19:54:51 Michael Niedermayer <michael at niedermayer.cc>:

> On Thu, Oct 31, 2024 at 02:40:57PM +0100, Leandro Santiago wrote:
>> When vulkan rendering is requested by the user and fails, ffplay should
>> exit graciously instead of crash due to a null pointer deref.
>> 
>> Signed-off-by: Leandro Santiago <leandrosansilva at gmail.com>
>> ---
>> fftools/ffplay.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>> 
>> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
>> index a596972769..56d0a36ca1 100644
>> --- a/fftools/ffplay.c
>> +++ b/fftools/ffplay.c
>> @@ -2612,6 +2612,11 @@ static int create_hwaccel(AVBufferRef **device_ctx)
>>      if (type == AV_HWDEVICE_TYPE_NONE)
>>          return AVERROR(ENOTSUP);
>> +    if (!vk_renderer) {
>> +        av_log(NULL, AV_LOG_ERROR, "Vulkan renderer is not available\n");
> 
> there is something wrong with this patch
> the "+" shouldnt be in teh 2nd column
> 
> thx
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> "Nothing to hide" only works if the folks in power share the values of
> you and everyone you know entirely and always will -- Tom Scott