[FFmpeg-devel] [PATCH 1/5] avformat/rpl: check channels

Michael Niedermayer michael at niedermayer.cc
Sun Nov 3 22:12:12 EET 2024


Fixes: 42537199/clusterfuzz-testcase-minimized-fuzzer_loadfile_direct-5447162658357248
Fixes: runtime error: signed integer overflow: -3330498059201358222 * 4 cannot be represented in type 'int64_t' (aka 'long')

Found-by: ossfuzz
Reported-by: Kacper Michajlow
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/rpl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/rpl.c b/libavformat/rpl.c
index 32a762b60a9..e971d0588f3 100644
--- a/libavformat/rpl.c
+++ b/libavformat/rpl.c
@@ -205,6 +205,8 @@ static int rpl_read_header(AVFormatContext *s)
         if (ast->codecpar->sample_rate < 0)
             return AVERROR_INVALIDDATA;
         channels                       = read_line_and_int(pb, &error);  // number of audio channels
+        if (channels <= 0)
+            return AVERROR_INVALIDDATA;
         error |= read_line(pb, line, sizeof(line));
         ast->codecpar->bits_per_coded_sample = read_int(line, &endptr, &error);  // audio bits per sample
         av_strlcpy(audio_type, endptr, RPL_LINE_LENGTH);
-- 
2.47.0



More information about the ffmpeg-devel mailing list