[FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

[Nicolas George]

Marton Balint (12024-11-04):
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavfilter/asrc_sine.c             |  16 +-
>  tests/ref/fate/copy-shortest1       |  58 ++---
>  tests/ref/fate/copy-shortest2       |  58 ++---
>  tests/ref/fate/filter-concat        | 344 ++++++++++++++--------------
>  tests/ref/fate/filter-concat-vfr    | 344 ++++++++++++++--------------
>  tests/ref/fate/filter-crazychannels |  64 +++---
>  tests/ref/fate/shortest             |  58 ++---
>  tests/ref/fate/swr-async-firstpts   |  34 +--
>  8 files changed, 488 insertions(+), 488 deletions(-)

Hi.

I dislike that the ref changes. What is the point of having tests if we
change the ref when we change the code.

Please split this patch into two parts: first one that changes the code
but not the ref by updating “sine=1000” into
“sine=1000.0000034…” using a float constant that gives the same value
(<<32) for dphi; then a second one that reverts the test to the simple
constants and updates the refs accordingly.

That way we can be sure it is really an increase in accuracy and nothing
more.

Also, please check the speed impact on speed on a 32 bits CPU. A real
one, not an emulation or compatibility mode, and preferably a low-end
one.

Regards,

-- 
  Nicolas George