[FFmpeg-devel] [PATCH 2/2] avcodec/x86/diracdsp: Migrate last remaining MMX function to SSE2

[Michael Niedermayer]

On Thu, Nov 07, 2024 at 06:25:14PM +0900, Kyosuke Kawakami wrote:
> The add_dirac_obmc8_mmx function was the only MMX function left. This
> patch migrates it to SSE2.
> 
> Signed-off-by: Kyosuke Kawakami <kawakami150708 at gmail.com>
> ---
>  libavcodec/x86/diracdsp.asm    |  4 +---
>  libavcodec/x86/diracdsp_init.c | 10 +++-------
>  2 files changed, 4 insertions(+), 10 deletions(-)

this seems to break fate:

--- ./tests/ref/fate/dirac	2024-11-08 01:56:45.380642896 +0100
+++ tests/data/fate/dirac	2024-11-09 12:54:45.409451735 +0100
@@ -4,32 +4,32 @@
 #dimensions 0: 320x240
 #sar 0: 1/1
 0,          0,          0,        1,   115200, 0xf73819e8
-0,          1,          1,        1,   115200, 0x082e3788
-0,          2,          2,        1,   115200, 0x9fe73790
-0,          3,          3,        1,   115200, 0x58f63cc4
-0,          4,          4,        1,   115200, 0xd91c3767
-0,          5,          5,        1,   115200, 0xac39658c
-0,          6,          6,        1,   115200, 0xd6d57406
-0,          7,          7,        1,   115200, 0x791b707f
-0,          8,          8,        1,   115200, 0x02e05e31
-0,          9,          9,        1,   115200, 0x7737ca43
-0,         10,         10,        1,   115200, 0xa9b5b019
-0,         11,         11,        1,   115200, 0x8b2685be
-0,         12,         12,        1,   115200, 0x2f547334
-0,         13,         13,        1,   115200, 0x9c2ba0ad
-0,         14,         14,        1,   115200, 0x17069da3
-0,         15,         15,        1,   115200, 0xbc7fadd1
-0,         16,         16,        1,   115200, 0xbf651cce
-0,         17,         17,        1,   115200, 0x2e1abc0d
-0,         18,         18,        1,   115200, 0xc6c9a945
-0,         19,         19,        1,   115200, 0x5234c510
-0,         20,         20,        1,   115200, 0x84b5ab26
-0,         21,         21,        1,   115200, 0xf01da61e
-0,         22,         22,        1,   115200, 0xfb339d74
-0,         23,         23,        1,   115200, 0x0973bf98
-0,         24,         24,        1,   115200, 0x7467023a
-0,         25,         25,        1,   115200, 0x3c8ba9a1
-0,         26,         26,        1,   115200, 0xdc699e3e
-0,         27,         27,        1,   115200, 0xe57f9d2e
-0,         28,         28,        1,   115200, 0x79b18bc4
-0,         29,         29,        1,   115200, 0x4c4c98a0
+0,          1,          1,        1,   115200, 0x79d478bd
+0,          2,          2,        1,   115200, 0x2cad71ae
+0,          3,          3,        1,   115200, 0xde5e70f0
+0,          4,          4,        1,   115200, 0x051eda0a
+0,          5,          5,        1,   115200, 0x8ddb0bc5
+0,          6,          6,        1,   115200, 0x2ef5b7f3
+0,          7,          7,        1,   115200, 0xac002aa2
+0,          8,          8,        1,   115200, 0xb535e712
+0,          9,          9,        1,   115200, 0x1e7f66bb
+0,         10,         10,        1,   115200, 0x61255fdb
+0,         11,         11,        1,   115200, 0x8ef6ba7a
+0,         12,         12,        1,   115200, 0x71e4330e
+0,         13,         13,        1,   115200, 0x277e78d8
+0,         14,         14,        1,   115200, 0xb4a01606
+0,         15,         15,        1,   115200, 0x2589c385
+0,         16,         16,        1,   115200, 0x698464a1
+0,         17,         17,        1,   115200, 0xa49ca790
+0,         18,         18,        1,   115200, 0xc993165c
+0,         19,         19,        1,   115200, 0x03650ebc
+0,         20,         20,        1,   115200, 0xa686e472
+0,         21,         21,        1,   115200, 0x5e265cd5
+0,         22,         22,        1,   115200, 0xcb6b5084
+0,         23,         23,        1,   115200, 0xc186b9e0
+0,         24,         24,        1,   115200, 0xa767fc74
+0,         25,         25,        1,   115200, 0x118894d1
+0,         26,         26,        1,   115200, 0x753246a0
+0,         27,         27,        1,   115200, 0x3e8268fc
+0,         28,         28,        1,   115200, 0x95107de0
+0,         29,         29,        1,   115200, 0x437035db
Test dirac failed. Look at tests/data/fate/dirac.err for details.
make: *** [tests/Makefile:311: fate-dirac] Error 1

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241109/0aaa90e3/attachment.sig>