[FFmpeg-devel] [PATCH] avformat/smoothstreamingenc: check return value of avcodec_parameters_copy()

[epirat07 at gmail.com]

On 21 Nov 2024, at 6:24, Marth64 wrote:

> Hi ePirat:
>
> I believe it is safe. ism_free() is invoked as the .deinit procedure
> which will free all of the contexts allocated in ism_write_header().
> To confirm this I triggered a fault with this condition and saw no
> leaks in valgrind. Also if putting a free there on the context, this
> appears to end up in double free segfault (proving the theory). So I
> think it is good. Please let me know if I missed anything.

Oh indeed sorry, I forgot it would call the deinit on failure too.

LGTM

>
> Thank you,
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".