[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: add CC format for user_data 0x05 0x02
Scott Theisen
scott.the.elm at gmail.com
Thu Nov 21 09:55:41 EET 2024
On 11/21/24 02:49, Scott Theisen wrote:
> On 11/21/24 01:52, Marth64 wrote:
>> Can the naming/comment in the code be changed to “DVB 0502”, DVB_0502,
>> etc.? In this way it is not referencing a particular provider and in the
>> future other if other custom DVB EIA608 techniques are supported (it is
>> possible there is more), they can be named similarly.
>
> Done. I only called it that because ccextractor did.
>
> I also don't see any significant difference with ccextractor's
> es_userdata.c, so I don't know why this would work and ccextractor
> didn't on your samples.
>
>>
>> LGTM otherwise.
>>
>> Thank you.
>
Use v3. I matched the whitespace better.
More information about the ffmpeg-devel
mailing list