[FFmpeg-devel] [PATCH 2/3] avformat/mov: Populate packet duration using stts atom instead of guessing

[James Almer]

On 11/21/2024 6:17 PM, Michael Niedermayer wrote:
> On Thu, Nov 21, 2024 at 12:23:41AM -0300, James Almer wrote:
>> From: Darren Mo <fumoboy007 at me.com>
>>
>> Fixes tickets #7855 and #11312.
>>
>> Co-authored-by: James Almer <jamrial at gmail.com>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> This is an alternative, better approach to the same issue.
>>
>>   libavformat/isom.h                            |   3 +
>>   libavformat/mov.c                             | 180 ++++++++++++++++--
>>   tests/ref/fate/copy-trac236                   |   4 +-
>>   tests/ref/fate/filter-fps                     |   1 +
>>   tests/ref/fate/filter-fps-cfr                 |   1 +
>>   tests/ref/fate/filter-meta-4560-rotate0       |   4 +-
>>   tests/ref/fate/gaplessenc-itunes-to-ipod-aac  |   2 +-
>>   tests/ref/fate/matroska-dovi-write-config8    |   4 +-
>>   .../fate/matroska-non-rotation-displaymatrix  |   6 +-
>>   tests/ref/fate/mov-aac-2048-priming           |   2 +-
>>   tests/ref/fate/mov-zombie                     |   4 +-
>>   11 files changed, 181 insertions(+), 30 deletions(-)
> 
> breaks fate
> 
> --- ./tests/ref/fate/mov-mp4-iamf-stereo	2024-11-17 02:14:20.475742935 +0100
> +++ tests/data/fate/mov-mp4-iamf-stereo	2024-11-21 22:14:37.421521040 +0100
> @@ -15,7 +15,7 @@
>   0,      27648,      27648,     4608,     1422, 0x2f9d47c5
>   0,      32256,      32256,     4608,     1768, 0x2a044b99
>   0,      36864,      36864,     4608,     1534, 0xb0b35a3f
> -0,      41472,      41472,     2628,      926, 0xc26a5eae
> +0,      41472,      41472,     4608,      926, 0xc26a5eae
>   [STREAM_GROUP]
>   index=0
>   id=0x1

There may be some use of uninitialized data somewhere. I'm looking at it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241121/a185c207/attachment.sig>