[FFmpeg-devel] [PATCH 04/12] swscale/internal: swap SWS_DITHER_NONE and SWS_DITHER_AUTO

[Michael Niedermayer]

On Mon, Oct 07, 2024 at 06:47:24PM +0200, Niklas Haas wrote:
> On Mon, 07 Oct 2024 00:15:32 +0200 Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Sat, Oct 05, 2024 at 09:23:55PM +0200, Niklas Haas wrote:
> > > From: Niklas Haas <git at haasn.dev>
> > >
> > > This is done for consistency with the other public enums which will be
> > > added in the upcoming swscale API refactor. I went through the code and checked
> > > carefully that the value of `dither` is never implicitly compared against
> > > zero, so this change should not break anything.
> > >
> > > Sponsored-by: Sovereign Tech Fund
> > > Signed-off-by: Niklas Haas <git at haasn.dev>
> > > ---
> > >  libswscale/swscale_internal.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > this breaks:
> >
> > ./ffmpeg -i lena.pnm -vf scale=iw:ih:flags=0x000002:sws_dither=0,format=bgr4_byte -bitexact whatever.bmp
> 
> This is expected, of course. Are you saying that the change in consistency is
> not worth the risk of breaking users who directly specify numeric IDs instead
> of using the symbolic names?

iam not really sure what to do but
0 has a feeling of "none" to me

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241007/f9291901/attachment.sig>