[FFmpeg-devel] [PATCH 4/4] fate/all: add missing crc/framecrc/md5/framemd5/pipe dependencies

Nicolas Gaullier nicolas.gaullier at cji.paris
Thu Oct 10 15:10:33 EEST 2024


>>-FATE_SAMPLES_DEMUX-$(call ALLYES, S337M_DEMUXER DOLBY_E_PARSER 
>>FRAMECRC_MUXER) += fate-s337m-demux
>>+FATE_SAMPLES_DEMUX-$(call FRAMECRC, S337M,, DOLBY_E_PARSER 
>>+FRAMECRC_MUXER) += fate-s337m-demux
>> fate-s337m-demux: CMD = framecrc -i $(TARGET_SAMPLES)/dolby_e/16-11 -c 
>> copy -ss 2 -t 1
>
>Ooops, I failed to remove the redundant FRAMECRC_MUXER here.
>I'll send a v2 early next week including other potential feedbacks if any.
>
>Nicolas

By the way, maybe I should have mentioned it, but I inserted many "call FRAMECRC" which may add some unrequired dependencies when streamcopying like here.
I think it is acceptable as a comment in the Makefile already states that PCM_S16LE_ENCODER and RAWVIDEO_ENCODER may be required although not necessary.
It is some kind of compromise to avoid numerous overlapping macros, and I guess anyone wanting a serious fate would have pcm_s16 and rawvideo encoders enabled.

Nicolas


More information about the ffmpeg-devel mailing list