[FFmpeg-devel] [PATCH 01/24] lavfi/vf_frei0r: switch to query_func2()

[Nicolas George]

Anton Khirnov (12024-10-12):
>  1 file changed, 7 insertions(+), 5 deletions(-)
>  1 file changed, 5 insertions(+), 3 deletions(-)
>  1 file changed, 6 insertions(+), 4 deletions(-)
>  1 file changed, 7 insertions(+), 6 deletions(-)
>  1 file changed, 6 insertions(+), 4 deletions(-)
>  1 file changed, 6 insertions(+), 3 deletions(-)
>  1 file changed, 6 insertions(+), 4 deletions(-)
>  1 file changed, 16 insertions(+), 9 deletions(-)
>  1 file changed, 7 insertions(+), 4 deletions(-)
>  1 file changed, 5 insertions(+), 3 deletions(-)
>  1 file changed, 9 insertions(+), 7 deletions(-)
>  1 file changed, 6 insertions(+), 4 deletions(-)
>  1 file changed, 6 insertions(+), 3 deletions(-)
>  1 file changed, 6 insertions(+), 4 deletions(-)
>  1 file changed, 7 insertions(+), 5 deletions(-)
>  1 file changed, 8 insertions(+), 5 deletions(-)
>  1 file changed, 7 insertions(+), 5 deletions(-)
>  1 file changed, 9 insertions(+), 7 deletions(-)
>  1 file changed, 12 insertions(+), 10 deletions(-)

How are this series and the previous similar ones considered
enhancements? They just add boilerplate code with no gain of features.

When adding a new more powerful but more verbose mechanism for some
feature, the proper way of doing things is to have the framework emulate
the needs of the new mechanism from the code currently there, so that
components that just work and do not need the extra power do not need to
be fastidiously changed.

This is making the code worse. Please stop and do better.

-- 
  Nicolas George