[FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

[epirat07 at gmail.com]

On 12 Oct 2024, at 23:08, Alexander Strasser via ffmpeg-devel wrote:

> The string representation of the FourCC is only used once for logging.
> ---
>
> Could also merge this with the first patch in this series and make
> it a single patch.
>
> Or drop this one.
>
> I don't have a strong opinion on these details.

LGTM, thanks.

Maybe just squash them into one commit.

>
>  libavcodec/dnxuc_parser.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/libavcodec/dnxuc_parser.c b/libavcodec/dnxuc_parser.c
> index 896758c794..12472c7a2d 100644
> --- a/libavcodec/dnxuc_parser.c
> +++ b/libavcodec/dnxuc_parser.c
> @@ -95,11 +95,8 @@ static int dnxuc_parse(AVCodecParserContext *s,
>      pc->nr_bytes = AV_RL32(buf+29+icmp_offset) - 8;
>
>      if (!avctx->codec_tag) {
> -        char fourcc_buf[AV_FOURCC_MAX_STRING_SIZE];
> -
> -        av_fourcc_make_string(fourcc_buf, pc->fourcc_tag);
>          av_log(avctx, AV_LOG_INFO, "dnxuc_parser: '%s' %dx%d %dbpp %d\n",
> -            fourcc_buf,
> +            av_fourcc2str(pc->fourcc_tag),
>              pc->width, pc->height,
>              (pc->nr_bytes*8)/(pc->width*pc->height),
>              pc->nr_bytes);
> --
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".