[FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

Nicolas George george at nsup.org
Tue Oct 15 09:15:49 EEST 2024


James Almer (12024-10-14):
> A new flag AVFILTER_FLAG_SUPPORT_COMMANDS that the user can check to ensure
> a call to avfilter_process_command() will not return ENOSYS could be added.

So you mean to have the same information twice in the source code of the
filter: once as the process_command callback, once as the flag. Having
the same information twice in the source code is a recipe for bugs:
unavoidably somebody will update one and not the other.

The correct way of doing this would be to add a function in libavfilter.

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list