[FFmpeg-devel] [PATCH 3/3] fate/vcodec: add a test for v410 pixel format raw video

[James Almer]

On 10/17/2024 7:47 PM, Sean McGovern wrote:
> Hi,
> 
> On Mon, Oct 14, 2024 at 9:54 AM James Almer <jamrial at gmail.com> wrote:
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   tests/fate/vcodec.mak             | 6 ++++++
>>   tests/ref/vsynth/vsynth1-v410     | 4 ++++
>>   tests/ref/vsynth/vsynth2-v410     | 4 ++++
>>   tests/ref/vsynth/vsynth3-v410     | 4 ++++
>>   tests/ref/vsynth/vsynth_lena-v410 | 4 ++++
>>   5 files changed, 22 insertions(+)
>>   create mode 100644 tests/ref/vsynth/vsynth1-v410
>>   create mode 100644 tests/ref/vsynth/vsynth2-v410
>>   create mode 100644 tests/ref/vsynth/vsynth3-v410
>>   create mode 100644 tests/ref/vsynth/vsynth_lena-v410
>>
>> diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
>> index 6a0a6a894a..a12eb43f22 100644
>> --- a/tests/fate/vcodec.mak
>> +++ b/tests/fate/vcodec.mak
>> @@ -456,6 +456,12 @@ fate-vsynth%-v408:               ENCOPTS = -pix_fmt uyva -sws_flags neighbor+bit
>>   fate-vsynth%-v408:               DECOPTS = -sws_flags neighbor+bitexact
>>   fate-vsynth%-v408:               CODEC   = rawvideo
>>
>> +FATE_VCODEC_SCALE-$(call ENCDEC, RAWVIDEO, MOV) += v410
>> +fate-vsynth%-v410:               ENCOPTS = -pix_fmt v30xle -sws_flags neighbor+bitexact
>> +fate-vsynth%-v410:               DECOPTS = -sws_flags neighbor+bitexact
>> +fate-vsynth%-v410:               CODEC   = rawvideo
>> +fate-vsynth%-v410:               FMT     = mov
>> +
>>   FATE_VCODEC_SCALE-$(call ENCDEC, AVUI, MOV)   += avui
>>   fate-vsynth%-avui:               ENCOPTS = -s pal -strict experimental -sws_flags neighbor+bitexact
>>   fate-vsynth%-avui:               DECOPTS = -sws_flags neighbor+bitexact $(DEFAULT_SIZE)
>> diff --git a/tests/ref/vsynth/vsynth1-v410 b/tests/ref/vsynth/vsynth1-v410
>> new file mode 100644
>> index 0000000000..6aa7762328
>> --- /dev/null
>> +++ b/tests/ref/vsynth/vsynth1-v410
>> @@ -0,0 +1,4 @@
>> +5978b496cf283b2a729df2769a7353a8 *tests/data/fate/vsynth1-v410.mov
>> +20276029 tests/data/fate/vsynth1-v410.mov
>> +c5ccac874dbf808e9088bc3107860042 *tests/data/fate/vsynth1-v410.out.rawvideo
>> +stddev:    0.00 PSNR:999.99 MAXDIFF:    0 bytes:  7603200/  7603200
>> diff --git a/tests/ref/vsynth/vsynth2-v410 b/tests/ref/vsynth/vsynth2-v410
>> new file mode 100644
>> index 0000000000..afc0c73dbe
>> --- /dev/null
>> +++ b/tests/ref/vsynth/vsynth2-v410
>> @@ -0,0 +1,4 @@
>> +40dda94467a8b6db90ce3edba680054b *tests/data/fate/vsynth2-v410.mov
>> +20276029 tests/data/fate/vsynth2-v410.mov
>> +36d7ca943916e1743cefa609eba0205c *tests/data/fate/vsynth2-v410.out.rawvideo
>> +stddev:    0.00 PSNR:999.99 MAXDIFF:    0 bytes:  7603200/  7603200
>> diff --git a/tests/ref/vsynth/vsynth3-v410 b/tests/ref/vsynth/vsynth3-v410
>> new file mode 100644
>> index 0000000000..0df57453f6
>> --- /dev/null
>> +++ b/tests/ref/vsynth/vsynth3-v410
>> @@ -0,0 +1,4 @@
>> +c1c0524dc868fd3198102e528fbefdbc *tests/data/fate/vsynth3-v410.mov
>> +231933 tests/data/fate/vsynth3-v410.mov
>> +a038ad7c3c09f776304ef7accdea9c74 *tests/data/fate/vsynth3-v410.out.rawvideo
>> +stddev:    0.00 PSNR:999.99 MAXDIFF:    0 bytes:    86700/    86700
>> diff --git a/tests/ref/vsynth/vsynth_lena-v410 b/tests/ref/vsynth/vsynth_lena-v410
>> new file mode 100644
>> index 0000000000..0d76ee20a6
>> --- /dev/null
>> +++ b/tests/ref/vsynth/vsynth_lena-v410
>> @@ -0,0 +1,4 @@
>> +9dec7983312b4c65f88d6232909ddf76 *tests/data/fate/vsynth_lena-v410.mov
>> +20276029 tests/data/fate/vsynth_lena-v410.mov
>> +dde5895817ad9d219f79a52d0bdfb001 *tests/data/fate/vsynth_lena-v410.out.rawvideo
>> +stddev:    0.00 PSNR:999.99 MAXDIFF:    0 bytes:  7603200/  7603200
>> --
>> 2.46.2
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 
> These tests now fail on ppc64, even with the recent addition of the
> missing reference files.
> Please have a look at this FATE instance:
> http://fate.ffmpeg.org/report.cgi?slot=ppc64-linux-gcc-14.2-ubsan-no_altivec&time=20241017222344

I assume it's a BE target, right? Do you have access to it? Can you test 
the following if so?

> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 5a14f34167..73cc6f5845 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -2617,7 +2617,7 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex
>                             || (track->par->codec_id == AV_CODEC_ID_RAWVIDEO && track->par->format == AV_PIX_FMT_YUYV422)
>                             || (track->par->codec_id == AV_CODEC_ID_RAWVIDEO && track->par->format == AV_PIX_FMT_VYU444)
>                             || (track->par->codec_id == AV_CODEC_ID_RAWVIDEO && track->par->format == AV_PIX_FMT_UYVA)
> -                           || (track->par->codec_id == AV_CODEC_ID_RAWVIDEO && track->par->format == AV_PIX_FMT_V30X)
> +                           || (track->par->codec_id == AV_CODEC_ID_RAWVIDEO && track->par->format == AV_PIX_FMT_V30XLE)
>  #if FF_API_V408_CODECID
>                             ||  track->par->codec_id == AV_CODEC_ID_V308
>                             ||  track->par->codec_id == AV_CODEC_ID_V408

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241017/70b6a427/attachment.sig>