[FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

[Alexander Strasser]

On 2024-10-18 21:02 +0200, Michael Niedermayer wrote:
> On Fri, Oct 18, 2024 at 02:02:48PM +0200, Alexander Strasser via ffmpeg-devel wrote:
> > This is as subject notes an RFC. I wanted to send it out quickly.
> > Didn't actually test on zlib systems yet (old and new).
> >
> > So it is not that heavily tested yet and maybe has rough edges I
> > didn't notice.
> >
> > I hope this would help to unbreak zlib-ng systems and not disturb
> > systems with older zlib versions.
> >
> > The strategy is
> >
> > 1. re-apply Ramiro's patch to use compression level 0
> > 2. fix the 2 tests that fail with older zlib with extra ref file
> >
> > The mechanism should only be used when other solutions are not
> > available. The alternative files could be dropped in the future
> > e.g. when no more fate clients fail because of it.

[...]

> --- ./tests/ref/fate/mov-cover-image.alt	2024-10-18 20:58:45.047495704 +0200
> +++ tests/data/fate/mov-cover-image	2024-10-18 20:59:42.975941144 +0200
> @@ -20,7 +20,7 @@
>  0,      -1088,      -1088,     1024,        6, 0x027e00e8, F=0x5
>  0,        -64,        -64,     1024,        6, 0x027e00e8
>  1,          0,          0,        0,    25441, 0xe82503b0
> -2,          0,          0,        0,  1084000, 0x70fc8139
> +2,          0,          0,        0,  1084000, 0x413c7ee9
>  0,        960,        960,     1024,        6, 0x027e00e8
>  0,       1984,       1984,     1024,        6, 0x027e00e8
>  0,       3008,       3008,     1024,        6, 0x027e00e8
> Test mov-cover-image failed. Look at tests/data/fate/mov-cover-image.err for details.
> make: *** [tests/Makefile:311: fate-mov-cover-image] Error 1

Ah sorry, my bad.
I forgot to apply the second hunk of the diff to the .alt ref file.

I would assume with that change added it should work.


  Alexander