[FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

Martin Storsjö martin at martin.st
Sat Oct 19 17:04:15 EEST 2024


On Sat, 19 Oct 2024, James Almer wrote:

> As there's no guarantee that the output will be exactly the same across implementations,
> just don't test it at all.
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> All tests covered now. Do we go this route, or update the zlib version of the
> failing FATE machines?

I would say that requiring an upgrade isn't reasonsble here.

This isn't only about fate.ffmpeg.org, but also about any developer - and 
user compiling ffmpeg for themselves - to be able to verify that their 
build is good.

If we go down the "enforce upgrades" path, we pretty much force all users 
to upgrade or stop using zlib. For still supported, not entirely ancient 
distributions like Ubuntu 20.04, that seems a bit harsh for something 
which is mainly an issue with our tests.

// Martin



More information about the ffmpeg-devel mailing list