[FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

Michael Niedermayer michael at niedermayer.cc
Sun Oct 20 01:09:38 EEST 2024


On Sat, Oct 19, 2024 at 10:33:58AM -0300, James Almer wrote:
> As there's no guarantee that the output will be exactly the same across implementations,
> just don't test it at all.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>

not objecting to this patch but

inflate is 550 lines of code
"Entire inflater (including optional zlib header parsing and Adler-32 checking) is implemented in a single function as a coroutine, which is separately available in a small (~550 line) source file: miniz_tinfl.c"

how much code do we need to write a simple store (not compress) ?
if i naively assume that decode must suport everything and encode
only one case that it chooses, iam perplexed how we still depend
on zlib for simply storing uncompressed zlib formated data

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241020/529ab84d/attachment.sig>


More information about the ffmpeg-devel mailing list