[FFmpeg-devel] [PATCH v3 05/18] swscale/utils: add SwsFormat abstraction and helpers

Michael Niedermayer michael at niedermayer.cc
Wed Oct 23 21:02:33 EEST 2024


On Sun, Oct 20, 2024 at 10:05:14PM +0200, Niklas Haas wrote:
> From: Niklas Haas <git at haasn.dev>
> 
> Groups together all relevant color metadata from an AVFrame. While we could
> use AVFrame directly, keeping it a separate struct has three advantages:
> 
> 1. Functions accepting an SwsFormat will definitely not care about the
>    data pointers.
> 2. It clearly separates sanitized and raw metadata, since the function to
>    construct an SwsFormat from an AVFrame will also sanitize.
> 3. It's slightly more lightweight to pass around.
> 
> Move these into a new header file "utils.h" to avoid crowding
> swscale_internal.h even more, and also to solve a circular dependency issue
> down the line.
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Niklas Haas <git at haasn.dev>
> ---
>  libswscale/utils.c | 64 +++++++++++++++++++++++++++++++++++++++
>  libswscale/utils.h | 75 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 139 insertions(+)
>  create mode 100644 libswscale/utils.h

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If the United States is serious about tackling the national security threats 
related to an insecure 5G network, it needs to rethink the extent to which it
values corporate profits and government espionage over security.-Bruce Schneier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241023/56a0c6c4/attachment.sig>


More information about the ffmpeg-devel mailing list