[FFmpeg-devel] [PATCH v3 0/2] avformat/mxfenc: Fix guess frame_rate

[Tomas Härdin]

mån 2024-09-02 klockan 11:52 +0200 skrev Nicolas Gaullier:
> Following yesterday posts by Anton/Tomas on version 1.
> 
> v3:
> - do not fall back to time_base (that was my v2)
> - do not remove "-r 25" in the fate test with streamcopy (see below)
> 
> What comes out:
> - mxfenc behaves the same as matroskaenc for example
> - avienc behaves differently: still sticked to time_base only
> 
> --
> 
> Another issue on this: "-r" as an output option with streamcopy
> is not honored with mxf/matroska, but it is with avienc. This is
> because
> streamcopy_init() only overrides time_base, not *_frame_rate.
> 
> In my understanding:
> - streamcopy_init() should override avg_frame_rate/r_frame_rate
> - avienc should be fixed similarly to this patch for mxfenc
> 
> [Note that if streamcopy_init() is fixed, fate-time_base data will be
> updated because currently the input frame_rate is (wrongly) probed as
> 50.]
> 
> Nicolas Gaullier (2):
>   avformat/mxfenc: Fix guess frame_rate
>   tests: Remove void -time_base overrides when streamcopying to mxf
> 
>  libavformat/mxfenc.c     | 8 ++++++--
>  tests/fate/ffmpeg.mak    | 4 ++--
>  tests/ref/fate/time_base | 2 +-
>  3 files changed, 9 insertions(+), 5 deletions(-)
> 

No major complaints from me.

/Tomas