[FFmpeg-devel] [PATCH 03/13] avcodec/decode: support applying LCEVC enhacements

[Derek Buitenhuis]

On 8/31/2024 5:31 PM, James Almer wrote:
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/avcodec.c       |  2 ++
>  libavcodec/avcodec.h       |  5 +++++
>  libavcodec/decode.c        | 42 +++++++++++++++++++++++++++++++++++++-
>  libavcodec/internal.h      |  2 ++
>  libavcodec/lcevcdec.c      |  2 ++
>  libavcodec/options_table.h |  1 +
>  libavcodec/pthread_frame.c |  7 +++++++
>  7 files changed, 60 insertions(+), 1 deletion(-)

No real opinion on the other patches, but this one feels really gross. I feel
liek we should not be adding new codec-specific things in AVCodecInternal or
in generic threding, decode, etc. It really feels quite wrong.

I probably missed discussion on this in previous revisions of this patch set,
but I wanted to get my thoughts in writing.

- Derek