[FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

Dale Curtis dalecurtis at chromium.org
Sat Sep 7 02:52:10 EEST 2024


Were there any more comments on this patch? Thanks!

- dale

On Mon, Aug 19, 2024 at 12:19 PM Dale Curtis <dalecurtis at chromium.org>
wrote:

> On Sat, Aug 17, 2024 at 12:25 PM James Almer <jamrial at gmail.com> wrote:
>
>> On 8/17/2024 3:04 PM, Michael Niedermayer wrote:
>> >
>> >
>> 20978/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5746381832847360
>> sent privately
>>
>
> Thanks for the sample Michael. I've confirmed it does not reproduce
> with my change when the checked bitstream reader is used -- and does
> reproduce with small_pad=true and the unchecked bitstream reader.
>
>
>> >
>> > thx
>>
>> Could the padding be changed to AV_INPUT_BUFFER_PADDING_SIZE instead of
>> 0 when small_padding is requested?
>>
>
> Either 0 or AV_INPUT_BUFFER_PADDING_SIZE works with the checked bitstream
> reader. AV_INPUT_BUFFER_PADDING_SIZE isn't sufficient to fix the fuzzer
> test case when small_pad=true and the unchecked bitstream reader is used
> though.
>
>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>
>


More information about the ffmpeg-devel mailing list