[FFmpeg-devel] [PATCH 09/13] avformat: add an LCEVC stream group

[James Almer]

On 9/6/2024 8:44 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-08-31 18:31:10)
>> +typedef struct AVStreamGroupLCEVC {
>> +    const AVClass *av_class;
>> +
>> +    /**
>> +     * Width of the final stream for presentation.
>> +     */
>> +    int width;
>> +    /**
>> +     * Height of the final image for presentation.
>> +     */
>> +    int height;
> 
> What's the point of exporting these separately when they are the same as
> the enhancement AVStream's dimensions?

The enhancement stream is of data type, so width/height are undefined in 
it. Hence including these here.

> 
>> +} AVStreamGroupLCEVC;
>> +
>>   enum AVStreamGroupParamsType {
>>       AV_STREAM_GROUP_PARAMS_NONE,
>>       AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT,
>>       AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION,
>>       AV_STREAM_GROUP_PARAMS_TILE_GRID,
>> +    AV_STREAM_GROUP_PARAMS_LCEVC,
> 
> This seems like it could use some documentation.

Yes, will add something.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240908/5956f96e/attachment.sig>