[FFmpeg-devel] [PATCH v4 2/4] libavformat/mxf: DNxUncompressed MXF related changes

[martin schitter]

On 10.09.24 15:14, Tomas Härdin wrote:
> tis 2024-09-10 klockan 16:06 +0200 skrev Martin Schitter:
>> ---
>>   libavformat/mxf.c    | 1 +
>>   libavformat/mxfdec.c | 1 +
>>   2 files changed, 2 insertions(+)
> 
> Commit message could be better, something like "Add DNxUncompressed
> ULs"

O.k. -- this will be "libavformat/mxf: add DNxUncompressed MXF ULs" in 
the corrected patch set.


>> +++ b/libavformat/mxf.c
>> +    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0E,0x04,0x02,0x01,0x02,0x1E,0x01,0x00 }, 16,      AV_CODEC_ID_DNXUC }, /* DNxUncompressed/SMPTE RDD 50 */
> 
> Are really all 16 bytes significant?
> 

>> +++ b/libavformat/mxfdec.c

>> +    { { 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x02,0x0d,0x01,0x03,0x01,0x02,0x1e,0x01,0x00 }, 14,      AV_CODEC_ID_DNXUC, NULL, 14 }, /* DNxUncompressed / SMPTE RDD 50 */
> 
> Here we have 14.. Also maybe we shouldn't copypaste ULs like this?

Thanks for finding this obvious discrepancy.

Indeed, 14 bytes should be searched (15th signifies frame/clip wrapped 
and 16th is just reserved).

In real life I've only found and tested the ...02 1E 01 00 variant until 
now, but clip wrapped content should hopefully work as well.

Will be fixed.

Martin