[FFmpeg-devel] [PATCH 09/13] avformat: add an LCEVC stream group

[James Almer]

On 9/9/2024 8:33 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-09-08 15:26:51)
>> On 9/6/2024 8:44 AM, Anton Khirnov wrote:
>>> Quoting James Almer (2024-08-31 18:31:10)
>>>> +typedef struct AVStreamGroupLCEVC {
>>>> +    const AVClass *av_class;
>>>> +
>>>> +    /**
>>>> +     * Width of the final stream for presentation.
>>>> +     */
>>>> +    int width;
>>>> +    /**
>>>> +     * Height of the final image for presentation.
>>>> +     */
>>>> +    int height;
>>>
>>> What's the point of exporting these separately when they are the same as
>>> the enhancement AVStream's dimensions?
>>
>> The enhancement stream is of data type, so width/height are undefined in
>> it. Hence including these here.
> 
> Why not define them then? Seems simpler and more straightforward to me.

I personally don't think re-defining the AVStream API in order to have 
two fields start meaning something for DATA type streams for the sake of 
only one codec_id is better than just having said fields defined in the 
specific stream group.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240911/82fc755d/attachment.sig>