[FFmpeg-devel] [PATCH 2/2] avformat: add farbfeld muxer and demuxer

[Michael Niedermayer]

On Sun, Sep 15, 2024 at 12:15:42AM -0500, Marcus B Spencer wrote:
> farbfeld is an uncompressed image format that is a part of suckless
> tools (https://tools.suckless.org).
> 
> Its documentation is available at https://tools.suckless.org/farbfeld.
> 
> Add support for this image format in avformat.
> 
> Signed-off-by: Marcus B Spencer <marcus at marcusspencer.xyz>
> ---
> Missing samples.
> Applied all the suggestions of Ramiro Polla, as long as made the
> FARBFELD_HEADER_LEN macro in farbfelddec.c be defined in terms of
> FARBFELD_MAGIC_LEN instead of 8.
> 
> Samples should soon be sent to samples-request.
> 
> 
> 
>  Changelog                  |   1 +
>  configure                  |   1 +
>  doc/general_contents.texi  |   4 ++
>  libavformat/Makefile       |   2 +
>  libavformat/allformats.c   |   4 +-
>  libavformat/farbfelddec.c  | 136 +++++++++++++++++++++++++++++++++++
>  libavformat/farbfeldenc.c  | 143 +++++++++++++++++++++++++++++++++++++
>  libavformat/version.h      |   4 +-
>  tests/Makefile             |   1 +
>  tests/fate/farbfeld.mak    |  11 +++
>  tests/ref/fate/farbfelddec |   6 ++
[...]
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -183,6 +183,7 @@ include $(SRC_PATH)/tests/fate/ffprobe.mak
>  include $(SRC_PATH)/tests/fate/fifo-muxer.mak
>  include $(SRC_PATH)/tests/fate/filter-audio.mak
>  # Must be included after vcodec.mak
> +include $(SRC_PATH)/tests/fate/farbfeld.mak
>  include $(SRC_PATH)/tests/fate/filter-video.mak
>  include $(SRC_PATH)/tests/fate/fits.mak
>  include $(SRC_PATH)/tests/fate/flac.mak
> diff --git a/tests/fate/farbfeld.mak b/tests/fate/farbfeld.mak
> new file mode 100644
> index 0000000000..576a080624
> --- /dev/null
> +++ b/tests/fate/farbfeld.mak
> @@ -0,0 +1,11 @@
> +FATE_FARBFELD += fate-farbfelddec
> +fate-farbfelddec: CMD = framecrc -i $(TARGET_SAMPLES)/farbfeld/test-512x512.ff
> +
> +FATE_FARBFELD += fate-farbfeldenc
> +fate-farbfeldenc: CMD = ffmpeg -i $(TARGET_SAMPLES)/farbfeld/test-512x512.ff -bitexact -f farbfeld -
> +fate-farbfeldenc: REF = $(SAMPLES)/farbfeld/test-512x512.ff
> +
> +FATE_FARBFELD-$(call ALLYES, IMAGE_FARBFELD_PIPE_DEMUXER IMAGE_FARBFELD_MUXER) += $(FATE_FARBFELD)
> +
> +FATE_SAMPLES_FFMPEG += $(FATE_FARBFELD-yes)
> +fate-farbfeld: $(FATE_FARBFELD-yes)

if you have a muxer, and this is rawvideo it should be possible to generate
the sample for the demuxer

see other cases where we have muxer and demuxer

uploading a new samples makes sense if theres something special about the
sample the muxer cannot create easily

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240916/cd8697b2/attachment.sig>