[FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

[Niklas Haas]

On Tue, 13 Aug 2024 14:38:48 -0700 Dale Curtis <dalecurtis at chromium.org> wrote:
> On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> 
> > Disabling random codec features seems like an anti-feature to me, in
> > the future it'll make every feature be questioned and compile-time
> > conditional, and make everything terrible.
> > If the context size is the major concern, maybe large structures
> > should be allocated when in use, rather than always?
> >
> 
> I agree with that, so here's a version which allocates dynamically instead.
> It passes FATE, but I didn't try with valgrind/msan in case I missed a
> cleanup path.

Hi,

Sorry, this one flew under my radar. The patch you posted seems correct to me,
though I would perhaps split it into separate patches for the h274db and SEI
changes.

I also agree with Chris that slice_tmp could probably be moved to the stack,
though I'll defer judgement on that to somebody who better knows FFmpeg's stack
policy.

> 
> - dale

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".