[FFmpeg-devel] [PATCH 7/7] lavfi/buffersink: deprecate functions obsoleted by AV_BUFFERSINK_FLAG_PARAMS

Anton Khirnov anton at khirnov.net
Mon Sep 23 19:24:39 EEST 2024


Quoting Nicolas George (2024-09-23 17:56:47)
> Anton Khirnov (12024-09-23):
> > That is all av_buffersink_get_*() except type and frame_rate, for which
> > AVFrame does not currently have fields.
> 
> NAK: an API that requires an allocated AVFrame to retrieve the
> parameters is significantly worst than the existing.

I fail to see how that is a problem, since you need an allocated AVFrame
to use the buffersink API anyway.

Not to mention that even if one allocates a dedicated AVFrame for the
parameters, the cost is trivial compared to actual filtering since it's
typically only done once per filtergraph.

On the other hand, the cost of a bloated symbol table is paid by
everyone whether they use the functions or not.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list