[FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

[Cameron Gutman]

On Mon, Sep 23, 2024 at 6:07 AM Zhao Zhili <quinkblack at foxmail.com> wrote:
>
>
>
> > On Sep 21, 2024, at 05:39, Martin Storsjö <martin at martin.st> wrote:
> >
> > From: Jan Ekström <jeebjp at gmail.com>
> >
> > Co-authored-by: Ruslan Chernenko <ractyfree at gmail.com>
> > Co-authored-by: Martin Storsjö <martin at martin.st>
> > ---
> > This is a touched up version of Jan and Ruslan's patches for
> > AV1 hwaccel via videotoolbox; I tried to polish the code a little
> > by not overwriting avctx->extradata in
> > ff_videotoolbox_av1c_extradata_create, and by factorizing out a
> > new function ff_videotoolbox_buffer_append.
>
> LGTM, although I don’t have a device with AV1 support.

I've asked for some testing from users with M3 MacBooks and it
appears to have problems with certain resolutions (notably 4K).

https://github.com/moonlight-stream/moonlight-qt/issues/1125

It's possible this is a Moonlight bug, but that seems unlikely
because VideoToolbox HEVC decoding works fine at 4K and
VideoToolbox AV1 works at 1080p and other resolutions.