[FFmpeg-devel] [PATCH] avformat/mov: get heif image rotation from irot box

[James Almer]

On 9/27/2024 1:43 PM, Anton Khirnov wrote:
> Quoting James Almer (2024-09-25 02:14:46)
>> Based on a patch by Hacene Bouaroua.
>>
>> Co-authored-by: Hacene Bouaroua <hbouaroua at freebox.fr>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   libavformat/avformat.h |  6 +++++
>>   libavformat/isom.h     |  1 +
>>   libavformat/mov.c      | 54 ++++++++++++++++++++++++++++++++++++++----
>>   3 files changed, 57 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
>> index 56c1c80289..a54aac0f3a 100644
>> --- a/libavformat/avformat.h
>> +++ b/libavformat/avformat.h
>> @@ -1082,6 +1082,12 @@ typedef struct AVStreamGroupTileGrid {
>>        * final image before presentation.
>>        */
>>       int height;
>> +
>> +    /**
>> +     * The angle in which the reconstructed image is rotated (in anti-clockwise
>> +     * direction) before presentation, in units of degrees.
>> +     */
>> +    AVRational rotation;
> 
> Should it not be a display matrix rather than just an angle?

What's the benefit? There's av_display_rotation_set() for that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240927/7283b383/attachment.sig>