[FFmpeg-devel] [PATCH v8 2/3] fftools: add memaddress log flag and disable printing addresses by default

[Gyan Doshi]

On 2025-04-09 02:55 pm, softworkz wrote:
> From: softworkz <softworkz at hotmail.com>
>
> This commit adds the memaddress log flag.
> When specifying this flag at the command line, context prefixes will
> be printed with memory addresses like in earlier ffmpeg versions.
>
> Example with memaddresses flag:
>
> [hevc @ 0000018e72a89cc0] .....
>
> without (new behavior):
>
> [hevc] .....
>
> Signed-off-by: softworkz <softworkz at hotmail.com>
> ---
>   fftools/ffmpeg.c     | 2 +-
>   fftools/ffplay.c     | 2 +-
>   fftools/ffprobe.c    | 2 +-
>   fftools/opt_common.c | 6 ++++++
>   4 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index dc321fb4a2..72887d6c5e 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -954,7 +954,7 @@ int main(int argc, char **argv)
>   
>       setvbuf(stderr,NULL,_IONBF,0); /* win32 runtime needs this */
>   
> -    av_log_set_flags(AV_LOG_SKIP_REPEATED);
> +    av_log_set_flags(AV_LOG_SKIP_REPEATED | AV_LOG_NO_PRINT_MEMADDRESS);
>       parse_loglevel(argc, argv, options);
>   
>   #if CONFIG_AVDEVICE
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 2a572fc3aa..9bd1fc2f22 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -3761,7 +3761,7 @@ int main(int argc, char **argv)
>   
>       init_dynload();
>   
> -    av_log_set_flags(AV_LOG_SKIP_REPEATED);
> +    av_log_set_flags(AV_LOG_SKIP_REPEATED | AV_LOG_NO_PRINT_MEMADDRESS);
>       parse_loglevel(argc, argv, options);
>   
>       /* register all codecs, demux and protocols */
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index abbd1dcf36..106435b827 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -4672,7 +4672,7 @@ int main(int argc, char **argv)
>   
>       init_dynload();
>   
> -    av_log_set_flags(AV_LOG_SKIP_REPEATED);
> +    av_log_set_flags(AV_LOG_SKIP_REPEATED | AV_LOG_NO_PRINT_MEMADDRESS);
>   
>       options = real_options;
>       parse_loglevel(argc, argv, options);
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index 2ac3fd4fb3..73a591acd8 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -1304,6 +1304,12 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg)
>               } else {
>                   flags |= AV_LOG_PRINT_DATETIME;
>               }
> +        } else if (av_strstart(token, "memaddress", &arg)) {

Too verbose a label. How about just 'mem'?

Regards,
Gyan



> +            if (cmd == '-') {
> +                flags |= AV_LOG_NO_PRINT_MEMADDRESS;
> +            } else {
> +                flags &= ~AV_LOG_NO_PRINT_MEMADDRESS;
> +            }
>           } else {
>               break;
>           }