[FFmpeg-devel] [PATCH] avformat/rtpdec_av1: Fix fragment continuation check when OBU_HAS_SIZE_FIELD is set

[Parallelc]

On Mon, Apr 14, 2025 at 3:13 PM Chris Hodges <Chris.Hodges at axis.com> wrote:
>
> Hi there,
>
> On 4/13/25 17:56, Parallelc wrote:
>
> > When OBU_HAS_SIZE_FIELD is set in the OBU header, frag_obu_size remains 0.
> > The code used !frag_obu_size to check for unexpected fragment continuation,
> > which resulted in incorrect drops. Introduce expect_frag_cont to explicitly
> > track continuation expectation.
>
> Good find! I didn't have sources that kept the OBU size field (just curious,
> what did you use to generate these RTP streams?), and your fix looks good
> to me (although I didn't verify it).
>
> --
> Best regards,
> Chris

Hi Chris,

Thanks for your review!

I'm currently working on adding WHIP and WHEP support to FFmpeg using
libdatachannel
in my personal fork: https://github.com/parallelcc/FFmpeg-WHIP-WHEP

So in my tests, the RTP streams are generated by libdatachannel or
Chrome WebRTC. They
packetize the encoder output directly, without removing the size field
like rtpenc_av1 does.

Best regards,
Parallelc