[FFmpeg-devel] [PATCH 0/3] avutil/dict2: Add AVDictionary2 with hash-based lookup

[Nicolas George]

ffmpegagent (HE12025-04-12):
> This whole patchset has been antirely authored by AI, wich means that I
> haven't written a single line of code.

You have got to be kidding. And not just because you waste everybody's
time submitting a series of bullshit code, but by the fact that you did
it in the first place, whether AI or yourself.

Please realize that Michael and I have barely begun to discuss the
qualitative enhancements we could get from a rewrite of the dictionary
API. And after just a few hours, you submit a series that implements…
none of them.

Coding is the easiest part of developing. It comes at the end of a long
maturation period. People can get to coding right away like you did when
they are dutifully executing the orders of whoever did the thinking
first, or when they do a school project that the teacher estimated was
doable, but certainly not when doing non-trivial things on an elite
project like FFmpeg, and even less when trying for a public API where
mistakes bite us for years.

Also, to answer a question in another mail, in case you have not figured
out by yourself:

> I'm not sure whether there are many usages of AVDictionary where stack
> allocation would be feasible or advantageous over the current way of
> "lazy init on first use", no?

I dare say that the ability to create the dictionary for avcodec_open2()
or for the title/artist/album of an audio file without dynamic
allocation and error checks is important. I will go as far as saying
that it is orders of magnitude more important than the asymptotic
performance.

As of feasibility, it looks to me like an easy task.

I would like to give the friendly advice to learn to walk before
annoying people who are talking about the best way to run a marathon (a
real one, in full armor with Persians on the heels), but in this day and
age that would cause half a dozen people to mail the community
committee, so please read this as just the expression on my own
frustration in the face of what I perceive as clueless comments in
serious discussions.

-- 
  Nicolas George