[FFmpeg-devel] [PATCH v10 2/3] fftools: add mem log flag and disable printing addresses by default

[Michael Niedermayer]

Hi

On Thu, Apr 10, 2025 at 08:51:04AM +0200, Nicolas George wrote:
> softworkz (HE12025-04-10):
> > From: softworkz <softworkz at hotmail.com>
> > 
> > This commit adds the mem log flag.
> > When specifying this flag at the command line, context prefixes will
> > be printed with memory addresses like in earlier ffmpeg versions.
> > 
> > Example with mem flag:
> > 
> > [hevc @ 0000018e72a89cc0] .....
> 
> As explained recently, strong opposition to this being the default.

just some random comments:

I think some way to distingish two different "hevc" instances
with high probability should remain.

About the addresses. Iam curious how frequently do people use them ?
and for what exactly ?

I do think *item_name() should be used more often. The "hevc" is a
quite bland identifcation of the instance.

in absence of a item_name(), that is *av_default_item_name()
which prints just the class name. I think printing the address by default
is reasonable otherwsie instances would be always indistingishable

beyond that, i dont remember using the addresses and would not
mind if it gets replaced by something more usefull more repeatable
with maybe some mem flag that could force them to be printed in all
cases

but i dont know, really depends on what the community prefers

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250416/47c97229/attachment.sig>