[FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map: benchmark code [BENCHMARK included]

[Michael Niedermayer]

On Tue, Apr 15, 2025 at 11:24:37PM +0000, softworkz . wrote:
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > Michael Niedermayer
> > Sent: Dienstag, 15. April 2025 22:51
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel at ffmpeg.org>
> > Subject: [FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map:
> > benchmark code [BENCHMARK included]
> > 
> 
> [..]
> 
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavutil/tests/map.c | 57
> > +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 57 insertions(+)
> > 
> > diff --git a/libavutil/tests/map.c b/libavutil/tests/map.c
> > index 38f0a153e68..90950769f98 100644
> > --- a/libavutil/tests/map.c
> > +++ b/libavutil/tests/map.c
> > @@ -26,6 +26,8 @@
> >  #include "libavutil/mem.h"
> >  #include "libavutil/map.h"
> > 
> > +#include "libavutil/timer.h"
> > +#include "libavutil/dict.h"
> > 
> >  static void print_set(const AVMap *s)
> >  {
> > @@ -37,6 +39,7 @@ static void print_set(const AVMap *s)
> > 
> >  int main(void)
> >  {
> > +#if 0
> >      void *our_cmp[] = {
> >          strcmp,
> >          av_map_strcmp_keyvalue,
> > @@ -185,6 +188,60 @@ int main(void)
> >          av_map_free(&set);
> >          av_assert0(!set);
> >      }
> > +#else
> > +#define N_ENTRIES 1000
> > +#define P 4
> > +    fprintf(stderr, "%d entries variable bytes at location %d-%d\n",
> > N_ENTRIES, P, P+1);
> > +    for (int runs = 0; runs < 1000; runs++) {
> > +        AVMap *map = av_map_new(av_strcasecmp, NULL, NULL);
> > +        for(int pass = 0; pass < 2; pass++) {
> > +            START_TIMER
> > +            unsigned r = 5;
> > +            for(int i=0; i<N_ENTRIES; i++) {
> > +                r = r*123 + 7;
> > +                char str[7] = "TEST";
> > +                str[P  ] = r;
> > +                str[P+1] = r>>8;
> > +                if(pass == 0) {
> > +                    av_map_add(map, str, 7, str, 7, 0);
> > +                } else {
> > +                    av_map_get(map, str, av_strcasecmp);
> > +                }
> > +            }
> > +            if (pass) {
> > +                STOP_TIMER("av_map_get")
> > +            } else {
> > +                STOP_TIMER("av_map_add")
> > +            }
> > +        }
> > +        av_map_free(&map);
> > +    }
> > +
> > +    for (int runs = 0; runs < 1000; runs++) {
> > +        AVDictionary *dict = NULL;
> > +        for(int pass = 0; pass < 2; pass++) {
> > +            START_TIMER
> > +            unsigned r = 5;
> > +            for(int i=0; i<N_ENTRIES; i++) {
> > +                r = r*123 + 7;
> > +                char str[7] = "TEST";
> > +                str[P  ] = r;
> > +                str[P+1] = r>>8;
> > +                if(pass == 0) {
> > +                    av_dict_set(&dict, str, str, 0);
> > +                } else {
> > +                    av_dict_get(dict, str, NULL, 0);
> > +                }
> > +            }
> > +            if (pass) {
> > +                STOP_TIMER("av_dict_get")
> > +            } else {
> > +                STOP_TIMER("av_dict_set")
> > +            }
> > +        }
> > +        av_dict_free(&dict);
> > +    }
> > +#endif
> > 
> >      return 0;
> >  }
> > --
> 
> Hi Michael,
> 
> is av_map_get() supposed tg work? I wasn't able to retrieve any values
> (always null return).

if you flip the #if 0 above this is a test that tests
av_map_get() and other functions.
Its new code and certainly bugs remain.
If you found cases that dont work, send a patch that adds these
cases to this test, and ill look at it eventually
or even better send a patch that fixes the issue you found

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250416/1b0e32a2/attachment.sig>