[FFmpeg-devel] [PATCH v2] avcodec/webvttdec: strip classes

Michael Niedermayer michael at niedermayer.cc
Thu Apr 17 03:24:04 EEST 2025


Hi

On Fri, Mar 21, 2025 at 04:55:02PM +0100, Leon Grutters wrote:
> If a supported tag has a class, e.g "<i.bold>" it is ignored entirely;
> so for example "<i.bold>Hello</i>" would be converted to "Hello{\i0}"
> instead of the intended "{\i1}Hello{\i0}".
> 
> Signed-off-by: Leon Grutters <gruttersleonbot2 at gmail.com>
> ---
>  libavcodec/webvttdec.c | 39 ++++++++++++++++++++++++++++-----------
>  1 file changed, 28 insertions(+), 11 deletions(-)

I see no fate tests changing. So it seems theres a lack of tests
maybe you can add some tests while you wait for someone to review
This would avoid future regressions

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250417/b6e775c2/attachment.sig>


More information about the ffmpeg-devel mailing list