[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: Eliminate fabs()

Michael Niedermayer michael at niedermayer.cc
Wed Apr 23 01:43:05 EEST 2025


Fixes: warning: using floating point absolute value function 'fabs' when argument is of integer type
No change in output
Changing variables to float worsens compression significantly

Found-by: ePirat
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/ffv1enc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index 75e40771b6f..6ab648fd805 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -1441,7 +1441,7 @@ static void encode_float32_remap(FFV1Context *f, FFV1SliceContext *sc,
                         cost = FFMAX((delta + mul/2)  / mul, 1);
                         float score = 1;
                         if (mul > 1) {
-                            score *= (fabs(delta - cost*mul)+1);
+                            score *= (FFABS(delta - cost*mul)+1);
                             if (mul_count > 1)
                                 score *= score;
                         }
-- 
2.49.0



More information about the ffmpeg-devel mailing list