[FFmpeg-devel] [PATCH 1/7] avformat/apvenc: Only allow APV

Mark Thompson sw at jkqxz.net
Sun Apr 27 22:41:20 EEST 2025


On 27/04/2025 19:42, Andreas Rheinhardt wrote:
> Patches attached.
> 
> - Andreas

> [PATCH 1/7] avformat/apvenc: Only allow APV

Oops, sure.

> [PATCH 2/7] avformat/apvenc: Remove unused header

Sure.

> [PATCH 3/7] avformat/apvdec: Use ffio_read_size()

Is there a cleaner way to discard very short files without reading them?  The minimum size of a valid is significantly larger than this, and an early failure would be nice rather than it get packetised and something later has to realise it's bad.

> [PATCH 4/7] avformat/apvdec: Remove inappropriate flags

What does the GENERIC_INDEX flag affect here?

Currently mpv does successfully seek in a raw file (to already-seen places), but this may or may not be related.

> [PATCH 5/7] avformat/apvenc: Add AVFMT_NOTIMESTAMPS flag

Sure.

> [PATCH 6/7] avcodec/apv_decode: Fix shadowing

Ambivalent about whether this is an improvement, but no objection.

> [PATCH 7/7] avcodec/apv_decode: Remove redundant log message

Sure.

Thanks,

- Mark



More information about the ffmpeg-devel mailing list